feat: allow to override ssl servername #3845
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3845 +/- ##
=======================================
Coverage 89.83% 89.83%
=======================================
Files 86 86
Lines 13596 13596
Branches 1606 1606
=======================================
Hits 12214 12214
Misses 1382 1382
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wellwelwel
added
needs tests
needs documentation
needs typings
|
Thanks for the idea, @bertho-zero. I believe that this isn't an alternative, but a continuation of #3835 and resolves #2560. When enabling this, it's a good idea to align the types and add the usage to the documentation (for example at https://sidorares.github.io/node-mysql2/docs/documentation/extras). Note I'll keep the PR as a draft for now. Feel free to continue the idea after #3835 (already merged). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally, you would be able to choose the server name used for SSL verification.
Another way to fix #2588 and #3835